Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

fix: return Vec<Datafile> instead of HashMap #126

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Jul 31, 2023

I find that task writer don't need to return HashMap<StructValue,DataFile>.

User will use it like following and it probably don't need to know the partition details.

let table = create_table();

let task_writer = table.task_writer();

// TaskWriter partition for user, they don't need to know the details.
task_writer.writer(records);

let res = task_writer.close();

let transaction = transaction::new(&mut table);

// Just pass the result to transaction.
transaction.append_datafile(res);

transaction.commit();

@ZENOTME ZENOTME merged commit b185d86 into icelake-io:main Jul 31, 2023
3 checks passed
@ZENOTME ZENOTME deleted the close branch July 31, 2023 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants